[test] More robust perf runner with profiler option.

[test] More robust perf runner with profiler option.

NOTRY=true

Committed: https://crrev.com/18d2c58cfd3ada09b9124b9d9cb41473d5d8eb76
Cr-Commit-Position: refs/heads/master@{#30731}

[Michael Achenbach, 2015-09-15 07:28:35]

machenbach@chromium.org changed reviewers:
+ bmeurer@chromium.org, bradnelson@chromium.org, gdeepti@chromium.org

[Michael Achenbach, 2015-09-15 07:28:35]

PTAL - Some perf tests are currently broken after
https://codereview.chromium.org/1327033003/

I totally forgot that we have tests that could have caught this. Now back to
100% coverage (~suppressions):

cd tools/unittests
python -m unittest run_perf_test

https://codereview.chromium.org/1341213002/diff/1/tools/run_perf.py
File tools/run_perf.py (left):

https://codereview.chromium.org/1341213002/diff/1/tools/run_perf.py#oldcode463
tools/run_perf.py:463: if self.binary != 'd8' and '--prof' in self.extra_flags:
Fix after https://codereview.chromium.org/1327033003/

https://codereview.chromium.org/1341213002/diff/1/tools/run_perf.py#oldcode657
tools/run_perf.py:657: print "Profiler option currently supported on Linux and
Mac OS."
Fix after https://codereview.chromium.org/1327033003/ - the else case would lead
to a failure below.

[Michael Achenbach, 2015-09-15 07:57:56]

machenbach@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Michael Achenbach, 2015-09-15 07:57:56]

+ Jakob

[Michael Achenbach, 2015-09-15 07:59:01]

https://codereview.chromium.org/1341213002/diff/1/tools/unittests/run_perf_te...
File tools/unittests/run_perf_test.py (right):

https://codereview.chromium.org/1341213002/diff/1/tools/unittests/run_perf_te...
tools/unittests/run_perf_test.py:460: self.assertEquals(0,
self._CallMain("--extra-flags=--prof"))
This is all c/p - the difference in this test is the extra-flags parameter.

[Jakob Kummerow, 2015-09-15 08:01:04]

lgtm

[Michael Achenbach, 2015-09-15 08:14:15]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2015-09-15 08:14:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341213002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341213002/1

[commit-bot: I haz the power, 2015-09-15 08:16:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-09-15 08:16:22]

Patchset 1 (id:??) landed as
https://crrev.com/18d2c58cfd3ada09b9124b9d9cb41473d5d8eb76
Cr-Commit-Position: refs/heads/master@{#30731}