Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: device/bluetooth/bluetooth_chromeos_unittest.cc

Issue 1341103004: Handle change of BLE address after pairing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased onto latest master Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_chromeos_unittest.cc
diff --git a/device/bluetooth/bluetooth_chromeos_unittest.cc b/device/bluetooth/bluetooth_chromeos_unittest.cc
index fbdfbb1e0fbfbaf5b1a2101b0ce3757ae79ec6a5..339aad0f31add94168292bd1e463618e658de4c1 100644
--- a/device/bluetooth/bluetooth_chromeos_unittest.cc
+++ b/device/bluetooth/bluetooth_chromeos_unittest.cc
@@ -2172,6 +2172,35 @@ TEST_F(BluetoothChromeOSTest, DeviceNameChanged) {
EXPECT_EQ(base::UTF8ToUTF16(new_name), devices[0]->GetName());
}
+TEST_F(BluetoothChromeOSTest, DeviceAddressChanged) {
+ // Simulate a change of address of a device.
+ GetAdapter();
+
+ BluetoothAdapter::DeviceList devices = adapter_->GetDevices();
+ ASSERT_EQ(2U, devices.size());
+ ASSERT_EQ(FakeBluetoothDeviceClient::kPairedDeviceAddress,
+ devices[0]->GetAddress());
+ ASSERT_EQ(base::UTF8ToUTF16(FakeBluetoothDeviceClient::kPairedDeviceName),
+ devices[0]->GetName());
+
+ // Install an observer; expect the DeviceAddressChanged method to be called
+ // when we change the alias of the device.
+ TestBluetoothAdapterObserver observer(adapter_);
+
+ FakeBluetoothDeviceClient::Properties* properties =
+ fake_bluetooth_device_client_->GetProperties(
+ dbus::ObjectPath(FakeBluetoothDeviceClient::kPairedDevicePath));
+
+ static const char* new_address = "D9:1F:FC:11:22:33";
armansito 2015/09/25 18:42:30 nit: s/new_address/kNewAddress/
jpawlowski1 2015/09/25 19:25:45 Done.
+ properties->address.ReplaceValue(new_address);
+
+ EXPECT_EQ(1, observer.device_address_changed_count());
+ EXPECT_EQ(1, observer.device_changed_count());
+ EXPECT_EQ(devices[0], observer.last_device());
+
+ EXPECT_EQ(std::string(new_address), devices[0]->GetAddress());
+}
+
TEST_F(BluetoothChromeOSTest, DeviceUuidsChanged) {
// Simulate a change of advertised services of a device.
GetAdapter();

Powered by Google App Engine
This is Rietveld 408576698