Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1341103004: Handle change of BLE address after pairing (Closed)

Created:
5 years, 3 months ago by jpawlowski1
Modified:
5 years, 2 months ago
Reviewers:
armansito
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, scheib+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle change of BLE address after pairing BUG=531763 Committed: https://crrev.com/39325abb296087634ff5c99fdbb08b22fdfc493d Cr-Commit-Position: refs/heads/master@{#350909}

Patch Set 1 #

Patch Set 2 : Added tests #

Patch Set 3 : Added another test #

Patch Set 4 : rebased onto latest master #

Total comments: 6

Patch Set 5 : Fixes #

Patch Set 6 : ***ADDED BY MISTAKE, OMMIT *** #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -133 lines) Patch
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h View 1 2 3 4 5 2 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc View 1 2 3 4 5 5 chunks +23 lines, -39 lines 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_connection.h View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_connection.cc View 1 2 3 4 5 3 chunks +2 lines, -4 lines 0 comments Download
M content/browser/bluetooth/bluetooth_dispatcher_host.h View 1 2 3 4 5 1 chunk +4 lines, -6 lines 0 comments Download
M content/browser/bluetooth/bluetooth_dispatcher_host.cc View 1 2 3 4 5 2 chunks +3 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_device.h View 1 2 3 4 5 2 chunks +10 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_device.cc View 1 2 3 4 5 2 chunks +9 lines, -6 lines 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.h View 1 2 3 4 5 3 chunks +6 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.cc View 1 2 3 4 5 3 chunks +32 lines, -15 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_chromeos_unittest.cc View 1 2 3 4 5 8 chunks +144 lines, -10 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_connection.h View 1 2 3 4 5 3 chunks +9 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_gatt_connection.cc View 1 2 3 4 5 2 chunks +9 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_connection_chromeos.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_gatt_connection_chromeos.cc View 1 2 3 4 5 3 chunks +18 lines, -13 lines 0 comments Download
M device/bluetooth/test/bluetooth_test.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/test/bluetooth_test.cc View 1 2 3 4 5 1 chunk +1 line, -3 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_device.h View 1 2 3 4 5 2 chunks +13 lines, -4 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_device.cc View 1 2 3 4 5 1 chunk +16 lines, -0 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_gatt_connection.h View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M device/bluetooth/test/mock_bluetooth_gatt_connection.cc View 1 2 3 4 5 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
armansito
Add a unit test for this please, both to the JS API code and to ...
5 years, 3 months ago (2015-09-14 23:58:50 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341103004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341103004/1
5 years, 3 months ago (2015-09-14 23:59:33 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/69130) ios_rel_device_ninja on ...
5 years, 3 months ago (2015-09-15 00:02:09 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341103004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341103004/60001
5 years, 3 months ago (2015-09-21 19:59:20 UTC) #8
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 3 months ago (2015-09-21 19:59:21 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341103004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341103004/60001
5 years, 3 months ago (2015-09-21 20:36:21 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-21 22:05:10 UTC) #14
armansito
lgtm https://codereview.chromium.org/1341103004/diff/60001/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc File chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc (right): https://codereview.chromium.org/1341103004/diff/60001/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc#newcode900 chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc:900: iter != service_id_to_device_address_.end(); iter++) { nit: for (auto ...
5 years, 2 months ago (2015-09-25 18:42:30 UTC) #15
jpawlowski1
https://codereview.chromium.org/1341103004/diff/60001/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc File chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc (right): https://codereview.chromium.org/1341103004/diff/60001/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc#newcode900 chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc:900: iter != service_id_to_device_address_.end(); iter++) { On 2015/09/25 18:42:30, armansito ...
5 years, 2 months ago (2015-09-25 19:25:45 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341103004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341103004/80001
5 years, 2 months ago (2015-09-25 19:30:13 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 2 months ago (2015-09-25 21:04:58 UTC) #20
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 21:05:37 UTC) #21
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/39325abb296087634ff5c99fdbb08b22fdfc493d
Cr-Commit-Position: refs/heads/master@{#350909}

Powered by Google App Engine
This is Rietveld 408576698