Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 13411003: Introduce fastbuild=2, which completely disables debug information. (Closed)

Created:
7 years, 8 months ago by Paweł Hajdan Jr.
Modified:
7 years, 8 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Introduce fastbuild=2, which completely disables debug information. Only to be used for compile-only builders. BUG=168411 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191876

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -9 lines) Patch
M build/common.gypi View 1 4 chunks +31 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paweł Hajdan Jr.
7 years, 8 months ago (2013-04-02 00:16:25 UTC) #1
M-A Ruel
https://codereview.chromium.org/13411003/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/13411003/diff/1/build/common.gypi#newcode1801 build/common.gypi:1801: # Clang creates chubby debug information, which makes linking ...
7 years, 8 months ago (2013-04-02 15:55:54 UTC) #2
Paweł Hajdan Jr.
PTAL
7 years, 8 months ago (2013-04-02 18:14:21 UTC) #3
M-A Ruel
lgtm, thanks a lot.
7 years, 8 months ago (2013-04-02 18:23:28 UTC) #4
Paweł Hajdan Jr.
7 years, 8 months ago (2013-04-02 19:42:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r191876 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698