Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1341043005: Don't reference instrumented-libraryes with sanitizers disabled. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
Reviewers:
Sam McNally, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't reference instrumented-libraryes with sanitizers disabled. Previously //build/config/sanitizer:deps unconditionally depended on //third_party/instrumented_libraries:deps. This dependency is only necessary //when compiling with a sanitizer, and in standalone other projects like nacl, //instrumented_libraries doesn't exist. This patch makes all contents of sanitizer:deps conditional on using a sanitizer, which matches what the documentation explicitly says. BUG= Committed: https://crrev.com/bc6f9a5b1858c70d852029f77020cabd3db879f6 Cr-Commit-Position: refs/heads/master@{#348719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M build/config/sanitizers/BUILD.gn View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
brettw
Scott: I think you originally set this up. Do you know why it used to ...
5 years, 3 months ago (2015-09-14 19:51:56 UTC) #2
sky
On 2015/09/14 19:51:56, brettw wrote: > Scott: I think you originally set this up. Do ...
5 years, 3 months ago (2015-09-14 20:07:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341043005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341043005/1
5 years, 3 months ago (2015-09-14 20:15:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 20:56:46 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bc6f9a5b1858c70d852029f77020cabd3db879f6 Cr-Commit-Position: refs/heads/master@{#348719}
5 years, 3 months ago (2015-09-14 20:57:26 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:37:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc6f9a5b1858c70d852029f77020cabd3db879f6
Cr-Commit-Position: refs/heads/master@{#348719}

Powered by Google App Engine
This is Rietveld 408576698