[Hotword] Putting preferences under search for hotword service. Putting behind a flag.

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
 
   //
@@ skipping 110 matching lines @@
 
       Preferences.getInstance().addEventListener('homepage',
           this.onHomePageChanged_.bind(this));
       Preferences.getInstance().addEventListener('homepage_is_newtabpage',
           this.onHomePageIsNtpChanged_.bind(this));
 
       $('change-home-page').onclick = function(event) {
         OptionsPage.navigateToPage('homePageOverlay');
       };
 
+      chrome.send('requestHotwordAvailabile');

[James Hawkins, 2014/01/14 00:53:50]

It's not clear how this call is tied to the added listener a line below.  For
example, what happens if (hypothetically) this browser call completes
synchronously?

[rpetterson, 2014/01/14 21:54:17]

Good point. I've swapped the order of them. Now, when the
"requestHotwordAvailable" message is sent, it should already be listening for
the reply.

+      Preferences.getInstance().addEventListener('hotword.search_enabled',
+          this.onHotwordSearchPrefChanged_.bind(this));
+
       if ($('set-wallpaper')) {
         $('set-wallpaper').onclick = function(event) {
           chrome.send('openWallpaperManager');
         };
       }
 
       $('themes-gallery').onclick = function(event) {
         window.open(loadTimeData.getString('themesGalleryURL'));
       };
       $('themes-reset').onclick = function(event) {
@@ skipping 718 matching lines @@
           this.showSectionWithAnimation_(section, container);
         else
           this.hideSectionWithAnimation_(section, container);
       } else {
         section.hidden = !event.value.value;
         this.onShowHomeButtonChangedCalled_ = true;
       }
     },
 
     /**
+     * Activates the Hotword section from the System settings page.
+     * @private
+     */
+    showHotwordSection_: function() {
+      $('hotword-search').hidden = false;
+    },
+
+    /**
+     * Event listener for the 'hotword search enabled' preference. Shows/hides
+     * the UI for updating hotword settings with animation.

[James Hawkins, 2014/01/14 00:53:50]

Do we need the 'with animation' part (in the comment and the method name)?  It
seems like an implementation details.

[rpetterson, 2014/01/14 21:54:17]

Done.

+     * @param {Event} event The preference change event.
+     */
+    onHotwordSearchPrefChanged_: function(event) {
+      var section = $('hotword-settings-section');
+      var container = $('hotword-settings-section-container');
+      if (event.value.value)

[James Hawkins, 2014/01/14 00:53:50]

Can you document what event.value.value represents?

[rpetterson, 2014/01/14 21:54:17]

Done.

+        this.showSectionWithAnimation_(section, container);
+      else
+        this.hideSectionWithAnimation_(section, container);
+    },
+
+    /**
      * Event listener for the 'homepage is NTP' preference. Updates the label
      * next to the 'Change' button.
      * @param {Event} event The preference change event.
      */
     onHomePageIsNtpChanged_: function(event) {
       if (!event.value.uncommitted) {
         $('home-page-url').hidden = event.value.value;
         $('home-page-ntp').hidden = !event.value.value;
       }
     },
@@ skipping 687 matching lines @@
     'setSpokenFeedbackCheckboxState',
     'setThemesResetButtonEnabled',
     'setVirtualKeyboardCheckboxState',
     'setupCloudPrintConnectorSection',
     'setupPageZoomSelector',
     'setupProxySettingsSection',
     'showBluetoothSettings',
     'showCreateProfileError',
     'showCreateProfileSuccess',
     'showCreateProfileWarning',
+    'showHotwordSection',
     'showManagedUserImportError',
     'showManagedUserImportSuccess',
     'showMouseControls',
     'showTouchpadControls',
     'updateAccountPicture',
     'updateAutoLaunchState',
     'updateDefaultBrowserState',
     'updateManagesSupervisedUsers',
     'updateSearchEngines',
     'updateStartupPages',
@@ skipping 14 matching lines @@
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });