Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Unified Diff: chrome/browser/ui/views/extensions/extension_message_bubble_view.h

Issue 134103002: Refactor the extension message bubbles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compile errors on non-Win platform Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_message_bubble_view.h
diff --git a/chrome/browser/ui/views/extensions/extension_message_bubble_view.h b/chrome/browser/ui/views/extensions/extension_message_bubble_view.h
index 4f07bb8f0894a9c03a2fed77a62e38e7c728cf67..492a1c4e08dc545a4e6ff481e319741ec6317aaa 100644
--- a/chrome/browser/ui/views/extensions/extension_message_bubble_view.h
+++ b/chrome/browser/ui/views/extensions/extension_message_bubble_view.h
@@ -46,7 +46,7 @@ class ExtensionMessageBubbleView : public ExtensionMessageBubble,
private:
ExtensionMessageBubbleView(
views::View* anchor_view,
- ExtensionMessageBubbleController::Delegate* delegate);
+ ExtensionMessageBubbleController* controller);
not at google - send to devlin 2014/01/10 21:28:43 take a scoped_ptr to indicate ownership
Finnur 2014/01/13 15:36:32 Done.
virtual ~ExtensionMessageBubbleView();
// Shows the bubble and updates the counter for how often it has been shown.
@@ -69,8 +69,8 @@ class ExtensionMessageBubbleView : public ExtensionMessageBubble,
base::WeakPtrFactory<ExtensionMessageBubbleView> weak_factory_;
- // The controller for the bubble. Weak, not owned by us.
- ExtensionMessageBubbleController::Delegate* delegate_;
+ // The controller for this bubble.
+ scoped_ptr<ExtensionMessageBubbleController> controller_;
// The headline, labels and buttons on the bubble.
views::Label* headline_;

Powered by Google App Engine
This is Rietveld 408576698