Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1341003002: Prepare RFHM for disabling swapped out state. (Closed)

Created:
5 years, 3 months ago by nasko
Modified:
5 years, 3 months ago
Reviewers:
alexmos
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare RFHM for disabling swapped out state. This CL ensures that RenderFrameHostManager doesn't create swapped out RenderViewHosts when swapped out state is disabled. It should be creating proxy objects instead. BUG=357747 Committed: https://crrev.com/56cd49d9f09779ac96a4885c09e3d9697c5c15bf Cr-Commit-Position: refs/heads/master@{#348688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M content/browser/frame_host/render_frame_host_manager.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nasko
Hey Alex, There is one codepath that needs to be fixed to create proxies instead ...
5 years, 3 months ago (2015-09-14 17:06:49 UTC) #2
alexmos
LGTM
5 years, 3 months ago (2015-09-14 17:38:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341003002/1
5 years, 3 months ago (2015-09-14 18:16:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 19:52:00 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/56cd49d9f09779ac96a4885c09e3d9697c5c15bf Cr-Commit-Position: refs/heads/master@{#348688}
5 years, 3 months ago (2015-09-14 19:52:53 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:36:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56cd49d9f09779ac96a4885c09e3d9697c5c15bf
Cr-Commit-Position: refs/heads/master@{#348688}

Powered by Google App Engine
This is Rietveld 408576698