Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1340923004: [heap] Concurrency support for heap book-keeping info (Closed)

Created:
5 years, 3 months ago by Michael Lippautz
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Concurrency support for heap book-keeping info. Adds concurrency support for: - MemoryChunk: Fragmentation counters - MemoryChunk: High-water mark - MemoryAllocator: Lowest and highest ever allocated addresses, size, and capacity R=hpayer@chromium.org BUG=chromium:524425 LOG=N Committed: https://crrev.com/63190721cda4966e01d71e92a730ce48ea789fbc Cr-Commit-Position: refs/heads/master@{#30749}

Patch Set 1 #

Patch Set 2 : Fix correctness #

Total comments: 2

Patch Set 3 : Addressed comment #

Patch Set 4 : Added MemoryAllocator's size_ and capacity_ fields #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -71 lines) Patch
M src/atomic-utils.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/heap/spaces.h View 1 2 3 9 chunks +68 lines, -52 lines 2 comments Download
M src/heap/spaces.cc View 1 2 3 8 chunks +21 lines, -19 lines 0 comments Download

Messages

Total messages: 22 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340923004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340923004/20001
5 years, 3 months ago (2015-09-15 09:26:36 UTC) #2
Michael Lippautz
5 years, 3 months ago (2015-09-15 09:29:40 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 09:51:25 UTC) #6
Hannes Payer (out of office)
... for heap book-keeping info. https://codereview.chromium.org/1340923004/diff/20001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/1340923004/diff/20001/src/heap/spaces.h#newcode1279 src/heap/spaces.h:1279: ptr = lowest_ever_allocated_.Value(); Can ...
5 years, 3 months ago (2015-09-15 09:55:36 UTC) #7
Michael Lippautz
https://codereview.chromium.org/1340923004/diff/20001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/1340923004/diff/20001/src/heap/spaces.h#newcode1279 src/heap/spaces.h:1279: ptr = lowest_ever_allocated_.Value(); On 2015/09/15 09:55:36, Hannes Payer wrote: ...
5 years, 3 months ago (2015-09-15 11:54:53 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340923004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340923004/40001
5 years, 3 months ago (2015-09-15 11:55:07 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340923004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340923004/60001
5 years, 3 months ago (2015-09-15 12:38:54 UTC) #12
Michael Lippautz
PTAL; all required counters, sizes, marks are in this CL now.
5 years, 3 months ago (2015-09-15 12:44:28 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 13:30:50 UTC) #15
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/1340923004/diff/60001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/1340923004/diff/60001/src/heap/spaces.h#newcode1143 src/heap/spaces.h:1143: intptr_t size = Size(); drop intptr_t size = ...
5 years, 3 months ago (2015-09-15 13:35:42 UTC) #16
Michael Lippautz
https://codereview.chromium.org/1340923004/diff/60001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/1340923004/diff/60001/src/heap/spaces.h#newcode1143 src/heap/spaces.h:1143: intptr_t size = Size(); On 2015/09/15 13:35:42, Hannes Payer ...
5 years, 3 months ago (2015-09-15 13:44:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340923004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340923004/60001
5 years, 3 months ago (2015-09-15 13:48:45 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-15 13:50:33 UTC) #20
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/63190721cda4966e01d71e92a730ce48ea789fbc Cr-Commit-Position: refs/heads/master@{#30749}
5 years, 3 months ago (2015-09-15 13:50:56 UTC) #21
Michael Lippautz
5 years, 3 months ago (2015-09-15 15:11:20 UTC) #22
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1340323002/ by mlippautz@chromium.org.

The reason for reverting is: crashing:
http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug%20-%203....

Powered by Google App Engine
This is Rietveld 408576698