Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc

Issue 13409003: Hide ContentClient getters from embedders so that they they don't reuse content's embedder API. The… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/loader/resource_loader_unittest.cc ('k') | content/browser/site_instance_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
===================================================================
--- content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc (revision 192622)
+++ content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc (working copy)
@@ -128,8 +128,7 @@
class MediaStreamDispatcherHostTest : public testing::Test {
public:
- MediaStreamDispatcherHostTest() : old_client_(NULL),
- old_browser_client_(NULL) {}
+ MediaStreamDispatcherHostTest() : old_browser_client_(NULL) {}
virtual ~MediaStreamDispatcherHostTest() {}
void WaitForResult() {
@@ -156,19 +155,16 @@
media_stream_manager_.get());
// Use the fake content client and browser.
- old_client_ = GetContentClient();
- old_browser_client_ = GetContentClient()->browser();
content_client_.reset(new TestContentClient);
SetContentClient(content_client_.get());
- content_client_->set_browser_for_testing(host_);
+ old_browser_client_ = SetBrowserClientForTesting(host_);
}
virtual void TearDown() OVERRIDE {
message_loop_->RunUntilIdle();
// Recover the old browser client and content client.
- GetContentClient()->set_browser_for_testing(old_browser_client_);
- SetContentClient(old_client_);
+ SetBrowserClientForTesting(old_browser_client_);
content_client_.reset();
// Delete the IO message loop to delete the device thread,
@@ -181,7 +177,6 @@
scoped_ptr<BrowserThreadImpl> io_thread_;
scoped_ptr<media::AudioManager> audio_manager_;
scoped_ptr<MediaStreamManager> media_stream_manager_;
- ContentClient* old_client_;
ContentBrowserClient* old_browser_client_;
scoped_ptr<ContentClient> content_client_;
scoped_ptr<MockMediaObserver> media_observer_;
« no previous file with comments | « content/browser/loader/resource_loader_unittest.cc ('k') | content/browser/site_instance_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698