Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: chrome/test/base/chrome_test_suite.cc

Issue 13409003: Hide ContentClient getters from embedders so that they they don't reuse content's embedder API. The… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/chrome_render_view_test.cc ('k') | chrome/test/base/in_process_browser_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/chrome_test_suite.cc
===================================================================
--- chrome/test/base/chrome_test_suite.cc (revision 192622)
+++ chrome/test/base/chrome_test_suite.cc (working copy)
@@ -133,14 +133,13 @@
DCHECK(!g_browser_process);
g_browser_process = new TestingBrowserProcess;
- DCHECK(!content::GetContentClient());
content_client_.reset(new chrome::ChromeContentClient);
+ content::SetContentClient(content_client_.get());
// TODO(ios): Bring this back once ChromeContentBrowserClient is building.
#if !defined(OS_IOS)
browser_content_client_.reset(new chrome::ChromeContentBrowserClient());
- content_client_->set_browser_for_testing(browser_content_client_.get());
+ SetBrowserClientForTesting(browser_content_client_.get());
#endif
- content::SetContentClient(content_client_.get());
SetUpHostResolver();
}
@@ -151,7 +150,6 @@
g_browser_process = NULL;
}
- DCHECK_EQ(content_client_.get(), content::GetContentClient());
// TODO(ios): Bring this back once ChromeContentBrowserClient is building.
#if !defined(OS_IOS)
browser_content_client_.reset();
« no previous file with comments | « chrome/test/base/chrome_render_view_test.cc ('k') | chrome/test/base/in_process_browser_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698