content/public/test/test_content_client_initializer.cc - Issue 13409003: Hide ContentClient getters from embedders so that they they don't reuse content's embedder API. The…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/test_content_client_initializer.cc

Issue 13409003: Hide ContentClient getters from embedders so that they they don't reuse content's embedder API. The… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/browser/risk/fingerprint.cc ('K') | « content/public/test/render_view_test.cc ('k') | content/renderer/browser_plugin/browser_plugin_browsertest.cc » ('j') | content/shell/shell_content_renderer_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/test_content_client_initializer.cc

===================================================================

--- content/public/test/test_content_client_initializer.cc (revision 192091)

+++ content/public/test/test_content_client_initializer.cc (working copy)

@@ -16,12 +16,11 @@

TestContentClientInitializer::TestContentClientInitializer() {

notification_service_.reset(new NotificationServiceImpl());

- DCHECK(!GetContentClient());

content_client_.reset(new TestContentClient);

SetContentClient(content_client_.get());

content_browser_client_.reset(new TestContentBrowserClient());

- content_client_->set_browser_for_testing(content_browser_client_.get());

+ content::SetBrowserClientForTesting(content_browser_client_.get());

}

TestContentClientInitializer::~TestContentClientInitializer() {

@@ -29,7 +28,6 @@

rph_factory_.reset();

notification_service_.reset();

- DCHECK_EQ(content_client_.get(), GetContentClient());

SetContentClient(NULL);

content_client_.reset();