Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6669)

Unified Diff: chrome/renderer/page_load_histograms.cc

Issue 13409003: Hide ContentClient getters from embedders so that they they don't reuse content's embedder API. The… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_histograms.cc
===================================================================
--- chrome/renderer/page_load_histograms.cc (revision 192091)
+++ chrome/renderer/page_load_histograms.cc (working copy)
@@ -439,11 +439,8 @@
// TODO(mpcomplete): remove the extension-related histograms after we collect
// enough data. http://crbug.com/100411
- chrome::ChromeContentRendererClient* client =
- static_cast<chrome::ChromeContentRendererClient*>(
- content::GetContentClient()->renderer());
-
- const bool use_adblock_histogram = client->IsAdblockInstalled();
+ const bool use_adblock_histogram =
+ chrome::ChromeContentRendererClient::IsAdblockInstalled();
if (use_adblock_histogram) {
UMA_HISTOGRAM_ENUMERATION(
"PLT.Abandoned_ExtensionAdblock",
@@ -474,7 +471,8 @@
}
}
- const bool use_adblockplus_histogram = client->IsAdblockPlusInstalled();
+ const bool use_adblockplus_histogram =
+ chrome::ChromeContentRendererClient::IsAdblockPlusInstalled();
if (use_adblockplus_histogram) {
UMA_HISTOGRAM_ENUMERATION(
"PLT.Abandoned_ExtensionAdblockPlus",
@@ -506,7 +504,7 @@
}
const bool use_webrequest_adblock_histogram =
- client->IsAdblockWithWebRequestInstalled();
+ chrome::ChromeContentRendererClient::IsAdblockWithWebRequestInstalled();
if (use_webrequest_adblock_histogram) {
UMA_HISTOGRAM_ENUMERATION(
"PLT.Abandoned_ExtensionWebRequestAdblock",
@@ -538,7 +536,7 @@
}
const bool use_webrequest_adblockplus_histogram =
- client->IsAdblockPlusWithWebRequestInstalled();
+ chrome::ChromeContentRendererClient::IsAdblockPlusWithWebRequestInstalled();
if (use_webrequest_adblockplus_histogram) {
UMA_HISTOGRAM_ENUMERATION(
"PLT.Abandoned_ExtensionWebRequestAdblockPlus",
@@ -570,7 +568,7 @@
}
const bool use_webrequest_other_histogram =
- client->IsOtherExtensionWithWebRequestInstalled();
+ chrome::ChromeContentRendererClient::IsOtherExtensionWithWebRequestInstalled();
if (use_webrequest_other_histogram) {
UMA_HISTOGRAM_ENUMERATION(
"PLT.Abandoned_ExtensionWebRequestOther",

Powered by Google App Engine
This is Rietveld 408576698