Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/common/chrome_content_client.cc

Issue 13409003: Hide ContentClient getters from embedders so that they they don't reuse content's embedder API. The… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/chrome_content_client.cc
===================================================================
--- chrome/common/chrome_content_client.cc (revision 192091)
+++ chrome/common/chrome_content_client.cc (working copy)
@@ -358,6 +358,13 @@
const char* const ChromeContentClient::kNaClOldPluginName =
::kNaClOldPluginName;
+std::string ChromeContentClient::GetProductImpl() {
+ chrome::VersionInfo version_info;
+ std::string product("Chrome/");
+ product += version_info.is_valid() ? version_info.Version() : "0.0.0.0";
+ return product;
+}
+
void ChromeContentClient::SetActiveURL(const GURL& url) {
child_process_logging::SetActiveURL(url);
}
@@ -403,10 +410,7 @@
}
std::string ChromeContentClient::GetProduct() const {
- chrome::VersionInfo version_info;
- std::string product("Chrome/");
- product += version_info.is_valid() ? version_info.Version() : "0.0.0.0";
- return product;
+ return GetProductImpl();
}
std::string ChromeContentClient::GetUserAgent() const {

Powered by Google App Engine
This is Rietveld 408576698