Avoid stack overflow in InputType::applyStep().

Avoid stack overflow in InputType::applyStep().

applyStep(current, count, ...) calls applyStep(aligned-current, count-1, ...) if
the current value doesn't match to the |step| value, and we assumed the second
call of applyStep didn't call another applyStep().
However, if an adjusted value is greater than the maximum value or is
smaller than the minimum value, we clamped the value.  So, the second
call of applyStep could be step-mismatched value, and called applyStep
continuously.

This CL does:
 - Remove the clamping code.
  The specification doesn't define such clamping.
 - Remove recursive calls.
  It was tail recursions.

Some tests fail intentionally because of the clamping removal.  A follow-up
CL will fix them.

BUG=529610
Committed: https://crrev.com/ebc1f01b3fdba6c8b1b2b1075e029cd317c685ee
git-svn-id: svn://svn.chromium.org/blink/trunk@202214 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[tkent, 2015-09-14 03:30:22]

Patchset #1 (id:1) has been deleted

[tkent, 2015-09-14 04:19:36]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org

[tkent, 2015-09-14 04:19:37]

Keishi, would you review this please?

https://codereview.chromium.org/1340883002/diff/20001/Source/core/html/forms/...
File Source/core/html/forms/InputType.cpp (left):

https://codereview.chromium.org/1340883002/diff/20001/Source/core/html/forms/...
Source/core/html/forms/InputType.cpp:787: if (newValue < stepRange.minimum())
This block is removed.

https://codereview.chromium.org/1340883002/diff/20001/Source/core/html/forms/...
Source/core/html/forms/InputType.cpp:792: setValueAsDecimal(newValue, count == 1
|| count == -1 ? eventBehavior : DispatchNoEvent, IGNORE_EXCEPTION);
We go through to the |else| clause.

https://codereview.chromium.org/1340883002/diff/20001/Source/core/html/forms/...
Source/core/html/forms/InputType.cpp:802: Decimal newValue = current +
stepRange.step() * count;
The code is not changed in this |else| clause.  Just a comment is added.

[keishi, 2015-09-14 05:37:09]

LGTM

[tkent, 2015-09-14 05:37:47]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2015-09-14 05:37:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1340883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1340883002/20001

[commit-bot: I haz the power, 2015-09-14 06:15:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 06:15:58]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2015-09-14 06:16:50]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2015-09-14 06:17:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1340883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1340883002/20001

[commit-bot: I haz the power, 2015-09-14 06:54:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 06:54:43]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2015-09-14 07:01:29]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2015-09-14 07:01:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1340883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1340883002/20001

[commit-bot: I haz the power, 2015-09-14 07:37:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 07:37:20]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2015-09-14 07:39:07]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2015-09-14 07:39:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1340883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1340883002/20001

[commit-bot: I haz the power, 2015-09-14 08:13:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 08:13:12]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2015-09-14 08:37:44]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2015-09-14 08:37:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1340883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1340883002/20001

[commit-bot: I haz the power, 2015-09-14 09:22:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 09:22:48]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2015-09-14 11:46:39]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2015-09-14 11:46:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1340883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1340883002/20001

[commit-bot: I haz the power, 2015-09-14 12:34:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 12:34:35]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2015-09-14 16:12:58]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2015-09-14 16:13:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1340883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1340883002/20001

[commit-bot: I haz the power, 2015-09-14 16:54:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 16:54:42]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2015-09-14 17:44:20]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2015-09-14 17:44:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1340883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1340883002/20001

[commit-bot: I haz the power, 2015-09-14 18:10:52]

Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202214

[commit-bot: I haz the power, 2015-09-23 12:34:19]

Patchset 1 (id:??) landed as
https://crrev.com/ebc1f01b3fdba6c8b1b2b1075e029cd317c685ee