Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1340803002: discardable pixelrefs are gone, update tests accordingly (Closed)

Created:
5 years, 3 months ago by reed2
Modified:
5 years, 3 months ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

discardable pixelrefs are gone, update tests accordingly BUG=skia:4328 Committed: https://skia.googlesource.com/skia/+/74bd953719c97e048def312973fd51320e7a00f0

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -185 lines) Patch
M bench/ETCBitmapBench.cpp View 1 2 1 chunk +12 lines, -10 lines 0 comments Download
M gm/astcbitmap.cpp View 1 2 2 chunks +18 lines, -20 lines 0 comments Download
M gm/etc1bitmap.cpp View 1 2 2 chunks +4 lines, -12 lines 0 comments Download
M gm/pictureimagegenerator.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/DrawBitmapRectTest.cpp View 2 chunks +9 lines, -6 lines 0 comments Download
M tests/ImageDecodingTest.cpp View 1 6 chunks +54 lines, -77 lines 0 comments Download
M tests/ImageTest.cpp View 2 chunks +0 lines, -48 lines 0 comments Download
M tests/JpegTest.cpp View 1 2 2 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
reed2
5 years, 3 months ago (2015-09-13 18:29:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340803002/20001
5 years, 3 months ago (2015-09-13 18:29:52 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 3 months ago (2015-09-13 18:29:53 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 3 months ago (2015-09-14 00:29:02 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340803002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340803002/40001
5 years, 3 months ago (2015-09-14 01:31:50 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-14 01:38:10 UTC) #11
scroggo
lgtm
5 years, 3 months ago (2015-09-14 13:15:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340803002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340803002/40001
5 years, 3 months ago (2015-09-14 15:51:33 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 15:52:17 UTC) #15
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/74bd953719c97e048def312973fd51320e7a00f0

Powered by Google App Engine
This is Rietveld 408576698