trunk/src/base/metrics/histogram_base.cc - Issue 13408012: Revert 192526 "Telemetry: Don't silently compare histograms from..."

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: trunk/src/base/metrics/histogram_base.cc

Issue 13408012: Revert 192526 "Telemetry: Don't silently compare histograms from..." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | trunk/src/tools/perf/perf_tools/histogram.py » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/metrics/histogram_base.h"	5 #include "base/metrics/histogram_base.h"

6	6

7 #include <climits>	7 #include <climits>

8	8

9 #include "base/logging.h"	9 #include "base/logging.h"

10 #include "base/json/json_string_value_serializer.h"	10 #include "base/json/json_string_value_serializer.h"

(...skipping 101 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
112 scoped_ptr<DictionaryValue> parameters(new DictionaryValue());	112 scoped_ptr<DictionaryValue> parameters(new DictionaryValue());

113 GetParameters(parameters.get());	113 GetParameters(parameters.get());

114	114

115 JSONStringValueSerializer serializer(output);	115 JSONStringValueSerializer serializer(output);

116 DictionaryValue root;	116 DictionaryValue root;

117 root.SetString("name", histogram_name());	117 root.SetString("name", histogram_name());

118 root.SetInteger("count", count);	118 root.SetInteger("count", count);

119 root.SetInteger("flags", flags());	119 root.SetInteger("flags", flags());

120 root.Set("params", parameters.release());	120 root.Set("params", parameters.release());

121 root.Set("buckets", buckets.release());	121 root.Set("buckets", buckets.release());

122 root.SetInteger("pid", getpid());

123 serializer.Serialize(root);	122 serializer.Serialize(root);

124 }	123 }

125	124

126 } // namespace base	125 } // namespace base

OLD	NEW