src/x64/full-codegen-x64.cc - Issue 13408005: Force context allocation for variables in generator scopes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/full-codegen-x64.cc

Issue 13408005: Force context allocation for variables in generator scopes. (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/full-codegen-x64.cc

diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc

index 322479dec60715085633e4642ff18b3c31d5ae29..670246c0ee702385363d429fd2b1ce07711f8510 100644

--- a/src/x64/full-codegen-x64.cc

+++ b/src/x64/full-codegen-x64.cc

@@ -160,6 +160,8 @@ void FullCodeGenerator::Generate() {

{ Comment cmnt(masm_, "[ Allocate locals");

int locals_count = info->scope()->num_stack_slots();

+ // Generators allocate locals, if any, in context slots.

+ ASSERT(!info->function()->is_generator() || locals_count == 0);

if (locals_count == 1) {

__ PushRoot(Heap::kUndefinedValueRootIndex);

} else if (locals_count > 1) {

« no previous file with comments | « src/v8globals.h ('k') | test/mjsunit/harmony/generators-instantiation.js » ('j') | no next file with comments »