Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/v8globals.h

Issue 13408005: Force context allocation for variables in generator scopes. (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/scopes.cc ('K') | « src/scopes.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | test/mjsunit/harmony/generators-iteration.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/v8globals.h
diff --git a/src/v8globals.h b/src/v8globals.h
index 4b4d312f91c04f484c2c6b9c3a787438db810605..673a4cc1c93b09f468a6f9428f2dc8f7397abd66 100644
--- a/src/v8globals.h
+++ b/src/v8globals.h
@@ -496,8 +496,8 @@ enum VariableMode {
INTERNAL, // like VAR, but not user-visible (may or may not
// be in a context)
- TEMPORARY, // temporary variables (not user-visible), never
- // in a context
+ TEMPORARY, // temporary variables (not user-visible), usually
+ // stack-allocated
Michael Starzinger 2013/04/05 11:38:42 nit: Let's add "... (unless the scope forces conte
wingo 2013/04/05 12:25:06 Done.
DYNAMIC, // always require dynamic lookup (we don't know
// the declaration)
« src/scopes.cc ('K') | « src/scopes.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | test/mjsunit/harmony/generators-iteration.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698