Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1340773002: Whitespace change to test gnumbd for master branch. (Closed)

Created:
5 years, 3 months ago by tandrii(chromium)
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Whitespace change to test gnumbd for master branch. R=machenbach@chromium.org BUG=530941 NOTRY=true NOPRESUBMIT=true Committed: https://crrev.com/d8eade4d7d84c4aba7f4c8ebbca04d475031c3f8 Cr-Commit-Position: refs/heads/master@{#30704}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/whitespace.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
tandrii(chromium)
5 years, 3 months ago (2015-09-12 15:43:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340773002/1
5 years, 3 months ago (2015-09-12 15:43:47 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-12 15:43:49 UTC) #5
tandrii_google
meh, how about lgtm from myself?
5 years, 3 months ago (2015-09-12 15:44:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340773002/1
5 years, 3 months ago (2015-09-12 15:44:57 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-12 15:44:59 UTC) #11
tandrii_google
Ok, i am not in the mood of making myself a committer temporarily, so I'll ...
5 years, 3 months ago (2015-09-12 15:46:23 UTC) #12
Michael Achenbach
lgtm
5 years, 3 months ago (2015-09-13 19:34:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340773002/1
5 years, 3 months ago (2015-09-13 19:35:22 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-13 19:35:36 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-13 19:40:28 UTC) #17
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d8eade4d7d84c4aba7f4c8ebbca04d475031c3f8
Cr-Commit-Position: refs/heads/master@{#30704}

Powered by Google App Engine
This is Rietveld 408576698