Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 134073005: Revert "Rate limit tree selection change side effects" (Closed)

Created:
6 years, 10 months ago by arv (Not doing code reviews)
Modified:
6 years, 10 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, tfarina, arv+watch_chromium.org
Visibility:
Public.

Description

Revert "Rate limit tree selection change side effects" This reverts r246805. The delay used for rate limiting the change caused the context menu to stop working (it gets hidden when the list id changes). BUG=339359, 336180 TBR=dbeam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248528

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -16 lines) Patch
M chrome/browser/resources/bookmark_manager/js/bmm/bookmark_tree.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/bookmark_manager/js/main.js View 1 chunk +1 line, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
arv (Not doing code reviews)
6 years, 10 months ago (2014-02-03 15:22:53 UTC) #1
arv (Not doing code reviews)
The CQ bit was checked by arv@chromium.org
6 years, 10 months ago (2014-02-03 15:22:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/134073005/1
6 years, 10 months ago (2014-02-03 15:23:05 UTC) #3
Dan Beam
lgtm
6 years, 10 months ago (2014-02-03 18:31:34 UTC) #4
commit-bot: I haz the power
Change committed as 248528
6 years, 10 months ago (2014-02-03 18:33:46 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 18:33:48 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 18:33:53 UTC) #7
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698