Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 134073002: New test fixture for DeviceMotionEventPump to avoid PlatformThread::Sleep (Closed)

Created:
6 years, 11 months ago by timvolodine
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, timvolodine, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

New test fixture for DeviceMotionEventPump to avoid PlatformThread::Sleep Implement a test fixture in DeviceMotionEventPumpTest to consistently test DeviceMotionEventPump. The new implementation also avoids calls to PlatformThread::Sleep() since it is generally undesirable in tests. BUG=333928 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245286

Patch Set 1 #

Patch Set 2 : reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -65 lines) Patch
M content/renderer/device_orientation/device_motion_event_pump_unittest.cc View 4 chunks +59 lines, -65 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
timvolodine
6 years, 11 months ago (2014-01-13 11:14:46 UTC) #1
Michael van Ouwerkerk
lgtm
6 years, 11 months ago (2014-01-13 15:17:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/134073002/60001
6 years, 11 months ago (2014-01-16 13:55:51 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=247306
6 years, 11 months ago (2014-01-16 15:31:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/134073002/60001
6 years, 11 months ago (2014-01-16 15:43:47 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests, nacl_integration, sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=247371
6 years, 11 months ago (2014-01-16 18:02:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/134073002/60001
6 years, 11 months ago (2014-01-16 18:05:28 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 19:41:30 UTC) #8
Message was sent while issue was closed.
Change committed as 245286

Powered by Google App Engine
This is Rietveld 408576698