ui/base/page_transition_types.cc - Issue 1340683002: Remove base's implicit_cast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/page_transition_types.cc

Issue 1340683002: Remove base's implicit_cast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: implicitcast: netcheckedcasts Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/base/page_transition_types.cc

diff --git a/ui/base/page_transition_types.cc b/ui/base/page_transition_types.cc

index 0bd86f613e3a2698145d01225183cd4c6f7b8ec0..31d100f775a9b102a1255251c56aa6b87ecbb5ef 100644

--- a/ui/base/page_transition_types.cc

+++ b/ui/base/page_transition_types.cc

@@ -13,8 +13,8 @@ bool PageTransitionCoreTypeIs(PageTransition lhs,

// Expect the rhs to be a compile time constant without qualifiers.

DCHECK(PageTransitionGetQualifier(rhs) == 0 &&

PageTransitionIsValidType(rhs));

- return implicit_cast<int>(PageTransitionStripQualifier(lhs)) ==

- implicit_cast<int>(PageTransitionStripQualifier(rhs));

+ return static_cast<int>(PageTransitionStripQualifier(lhs)) ==

+ static_cast<int>(PageTransitionStripQualifier(rhs));

}

PageTransition PageTransitionStripQualifier(PageTransition type) {