net/disk_cache/simple/simple_index_file.cc - Issue 1340683002: Remove base's implicit_cast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/simple/simple_index_file.cc

Issue 1340683002: Remove base's implicit_cast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: implicitcast: . Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/simple/simple_index_file.cc

diff --git a/net/disk_cache/simple/simple_index_file.cc b/net/disk_cache/simple/simple_index_file.cc

index c013084041f301cbd5ee378eb0642436d09ba910..6d9cdb1bce1d35f1273d2ada484cd2e075b6f360 100644

--- a/net/disk_cache/simple/simple_index_file.cc

+++ b/net/disk_cache/simple/simple_index_file.cc

@@ -77,7 +77,7 @@ bool WritePickleFile(base::Pickle* pickle, const base::FilePath& file_name) {

int bytes_written =

file.Write(0, static_cast<const char*>(pickle->data()), pickle->size());

- if (bytes_written != implicit_cast<int>(pickle->size())) {

+ if (bytes_written != static_cast<int>(pickle->size())) {

vmpstr 2015/09/11 21:31:16 checked_cast?

danakj 2015/09/11 21:33:30 Yep

simple_util::SimpleCacheDeleteFile(file_name);

return false;

}