Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: ui/base/page_transition_types.cc

Issue 1340683002: Remove base's implicit_cast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: implicitcast: numericstest Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_client_session_test.cc ('k') | ui/views/style/mac/dialog_button_border_mac_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/page_transition_types.cc
diff --git a/ui/base/page_transition_types.cc b/ui/base/page_transition_types.cc
index 0bd86f613e3a2698145d01225183cd4c6f7b8ec0..62c4e5aaba2777238d20ac1491844b2c4bb6eb6c 100644
--- a/ui/base/page_transition_types.cc
+++ b/ui/base/page_transition_types.cc
@@ -11,10 +11,9 @@ namespace ui {
bool PageTransitionCoreTypeIs(PageTransition lhs,
PageTransition rhs) {
// Expect the rhs to be a compile time constant without qualifiers.
- DCHECK(PageTransitionGetQualifier(rhs) == 0 &&
- PageTransitionIsValidType(rhs));
- return implicit_cast<int>(PageTransitionStripQualifier(lhs)) ==
- implicit_cast<int>(PageTransitionStripQualifier(rhs));
+ DCHECK_EQ(PageTransitionGetQualifier(rhs), 0);
+ DCHECK(PageTransitionIsValidType(rhs));
+ return PageTransitionStripQualifier(lhs) == PageTransitionStripQualifier(rhs);
}
PageTransition PageTransitionStripQualifier(PageTransition type) {
« no previous file with comments | « net/tools/quic/quic_client_session_test.cc ('k') | ui/views/style/mac/dialog_button_border_mac_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698