Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1340563003: remove dead code not mentioned in any GYP (Closed)

Created:
5 years, 3 months ago by mtklein_C
Modified:
5 years, 3 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove dead code not mentioned in any GYP BUG=skia: Committed: https://skia.googlesource.com/skia/+/4c9281d1036606e52390f28dc964d53acf0c44b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -60 lines) Patch
D src/gpu/GrCommandBuilder.h View 1 chunk +0 lines, -41 lines 0 comments Download
D src/gpu/GrCommandBuilder.cpp View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
5 years, 3 months ago (2015-09-14 13:26:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340563003/1
5 years, 3 months ago (2015-09-14 13:26:58 UTC) #4
bsalomon
lgtm
5 years, 3 months ago (2015-09-14 13:32:47 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-14 13:32:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340563003/1
5 years, 3 months ago (2015-09-14 13:33:17 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 13:33:51 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4c9281d1036606e52390f28dc964d53acf0c44b7

Powered by Google App Engine
This is Rietveld 408576698