Fix Mac Breakpad host tools to build in Linux cross-compile

src/common/mac/file_id.cc

 // Copyright (c) 2006, Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
@@ skipping 27 matching lines @@
 #include <unistd.h>
 
 #include "common/mac/file_id.h"
 #include "common/mac/macho_id.h"
 
 using MacFileUtilities::MachoID;
 
 namespace google_breakpad {
 
 FileID::FileID(const char *path) {
-  strlcpy(path_, path, sizeof(path_));
+  strncpy(path_, path, sizeof(path_) - 1);

[Mark Mentovai, 2015/09/11 15:49:50]

strlcpy() guarantees NUL-termination, but strncpy() doesn’t, so you need to
ensure that path_[sizeof(path_) - 1] = '\0'. But actually, there’s a better
alternative: snprintf does guarantee NUL-termination and is a more portable
replacement for strlcpy() than strncpy():

  sprintf(path_, sizeof(path_), "%s", path);

This recurs elsewhere in the change.

[Ted Mielczarek, 2015/09/15 12:58:36]

Done.

 }
 
 bool FileID::FileIdentifier(unsigned char identifier[16]) {
   int fd = open(path_, O_RDONLY);
   if (fd == -1)
     return false;
 
   MD5Context md5;
   MD5Init(&md5);
 
@@ skipping 37 matching lines @@
         static_cast<char>((hi >= 10) ? ('A' + hi - 10) : ('0' + hi));
     buffer[buffer_idx++] =
         static_cast<char>((lo >= 10) ? ('A' + lo - 10) : ('0' + lo));
   }
 
   // NULL terminate
   buffer[(buffer_idx < buffer_length) ? buffer_idx : buffer_idx - 1] = 0;
 }
 
 }  // namespace google_breakpad