Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 1340523004: Implement USB connection events through the WebUSB client interface. (Closed)

Created:
5 years, 3 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 3 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Implement USB connection events through the WebUSB client interface. This patch adds an observer to WebUSBClient so that the embeder can provide device connect and disconnect events. This interface is then used to dispatch these events. WebUSBClient::setObserver can be made a pure virtual function once Chrome's WebUSBClientImpl implements it. BUG=492204 Committed: https://crrev.com/5014ab0d6b767a71e555d8764939f403c2c52a7c git-svn-id: svn://svn.chromium.org/blink/trunk@202309 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : Change Member back to PersistentWillBeMember. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -7 lines) Patch
M Source/modules/webusb/USB.h View 3 chunks +10 lines, -1 line 0 comments Download
M Source/modules/webusb/USB.cpp View 3 chunks +21 lines, -0 lines 0 comments Download
M Source/modules/webusb/USBConnectionEvent.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webusb/USBConnectionEvent.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M public/platform/modules/webusb/WebUSBClient.h View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years, 3 months ago (2015-09-15 17:35:26 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 3 months ago (2015-09-15 18:17:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340523004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340523004/1
5 years, 3 months ago (2015-09-15 18:18:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/54743)
5 years, 3 months ago (2015-09-15 18:39:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340523004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340523004/20001
5 years, 3 months ago (2015-09-15 19:04:22 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/107448)
5 years, 3 months ago (2015-09-15 21:28:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340523004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340523004/20001
5 years, 3 months ago (2015-09-15 21:39:49 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202309
5 years, 3 months ago (2015-09-16 01:40:29 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:52:40 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5014ab0d6b767a71e555d8764939f403c2c52a7c

Powered by Google App Engine
This is Rietveld 408576698