Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: net/websockets/websocket_deflate_parameters.h

Issue 1340523002: Fix WebSocketServer extension parser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ws-constructor-fix
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/websockets/websocket_deflate_parameters.h
diff --git a/net/websockets/websocket_deflate_parameters.h b/net/websockets/websocket_deflate_parameters.h
index d0c73bfff5a14157356c2a9ae8c42ca9f108abad..5d6d9965e87ec6e0413cc4f044f42398ec7d6ffd 100644
--- a/net/websockets/websocket_deflate_parameters.h
+++ b/net/websockets/websocket_deflate_parameters.h
@@ -95,6 +95,13 @@ class NET_EXPORT_PRIVATE WebSocketDeflateParameters {
client_max_window_bits_ = WindowBits(bits, true, true);
}
+ int PermissiveServerMaxWindowBits() const {
+ return server_max_window_bits_.PermissiveBits();
+ }
+ int PermissiveClientMaxWindowBits() const {
+ return client_max_window_bits_.PermissiveBits();
+ }
+
// Return true if |bits| is valid as a max_window_bits value.
static bool IsValidWindowBits(int bits) { return 8 <= bits && bits <= 15; }
@@ -104,6 +111,8 @@ class NET_EXPORT_PRIVATE WebSocketDeflateParameters {
WindowBits(int16_t bits, bool is_specified, bool has_value)
: bits(bits), is_specified(is_specified), has_value(has_value) {}
+ int PermissiveBits() const { return is_specified && has_value ? bits : 15; }
+
int16_t bits;
// True when "window bits" parameter appears in the parameters.
bool is_specified;

Powered by Google App Engine
This is Rietveld 408576698