Fix WebSocketServer extension parser.

net/websockets/websocket_extension.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/websockets/websocket_extension.h"
 
 #include <map>
 #include <string>
 
 #include "base/logging.h"
+#include "net/http/http_util.h"
 
 namespace net {
 
 WebSocketExtension::Parameter::Parameter(const std::string& name)
     : name_(name) {}
 
 WebSocketExtension::Parameter::Parameter(const std::string& name,
                                          const std::string& value)
     : name_(name), value_(value) {
   DCHECK(!value.empty());
@@ skipping 17 matching lines @@
   std::multimap<std::string, std::string> this_parameters, other_parameters;
   for (const auto& p : parameters_) {
     this_parameters.insert(std::make_pair(p.name(), p.value()));
   }
   for (const auto& p : other.parameters_) {
     other_parameters.insert(std::make_pair(p.name(), p.value()));
   }
   return this_parameters == other_parameters;
 }
 
+std::string WebSocketExtension::ToString() const {
+  if (name_.empty()) {
+    return std::string();
+  }
+
+  std::string result = name_;
+
+  for (const auto& param : parameters_) {
+    result += "; " + param.name();
+    if (!param.HasValue())
+      continue;
+
+    // |extension-param| must be a token and we don't need to quote it.
+    DCHECK(HttpUtil::IsToken(param.value()));

[tyoshino (SeeGerritForStatus), 2015/09/17 02:24:37]

the parser is ok. it's checking if the unquoted data consists of token.

we should also add DCHECK to the Parameter constructor?

[yhirano, 2015/09/17 03:32:15]

Done.

+    result += "=" + param.value();
+  }
+  return result;
+}
+
 }  // namespace net