Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 1340513002: bindings/oilpan: Stops using ScriptWrappable pointers already collected by GC. (Closed)

Created:
5 years, 3 months ago by Yuki
Modified:
5 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

bindings/oilpan: Stops using ScriptWrappable pointers already collected by GC. Garbage collected objects can be collected by Oilpan by the time when ScriptWrappable::secondWeakCallback is called. In that case, secondWeakCallback tries to cast a pointer to the already-collected object to ScriptWrappable*. CFI(Control Flow Integrity) detects this cast as a bad cast because vtbl doesn't match. This CL fixes the issue making it not call secondWeakCallback for garbage collected objects. BUG=528798 Committed: https://crrev.com/a923a78d56bf56317f018ed6fbdc42e0ec8fc9a3 git-svn-id: svn://svn.chromium.org/blink/trunk@202133 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -19 lines) Patch
M Source/bindings/core/v8/ScriptWrappable.h View 3 chunks +22 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/WrapperTypeInfo.h View 1 chunk +17 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yuki
Could you review this CL?
5 years, 3 months ago (2015-09-11 12:45:30 UTC) #2
haraken
Thanks for catching this! LGTM.
5 years, 3 months ago (2015-09-11 12:55:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340513002/1
5 years, 3 months ago (2015-09-11 12:58:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202133
5 years, 3 months ago (2015-09-11 13:02:22 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:21:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a923a78d56bf56317f018ed6fbdc42e0ec8fc9a3

Powered by Google App Engine
This is Rietveld 408576698