chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc - Issue 1340493002: Add initial version of chrome://popular-sites-internals page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Issue 1340493002: Add initial version of chrome://popular-sites-internals page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@finch_country_version

Patch Set: review3 Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/popular_sites_internals.js ('k') | chrome/browser/ui/webui/popular_sites_internals_message_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

index 0d5c74510b66f9a200149d487f23bc61447c20c8..5fd36fa7643fc101735c65835e0ecf9e85f17f4e 100644

--- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

+++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

@@ -114,6 +114,10 @@

#include "chrome/browser/ui/webui/inspect_ui.h"

#endif

+#if defined(OS_ANDROID)

+#include "chrome/browser/ui/webui/popular_sites_internals_ui.h"

+#endif

#if defined(OS_CHROMEOS)

#include "base/sys_info.h"

#include "chrome/browser/ui/webui/chromeos/bluetooth_pairing_ui.h"

@@ -500,6 +504,10 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,

if (url.host() == chrome::kChromeUIInspectHost)

return &NewWebUI<InspectUI>;

#endif

+#if defined(OS_ANDROID)

+ if (url.host() == chrome::kChromeUIPopularSitesInternalsHost)

+ return &NewWebUI<PopularSitesInternalsUI>;

+#endif

#if !defined(OS_CHROMEOS) && !defined(OS_ANDROID) && !defined(OS_IOS)

if (url.host() == chrome::kChromeUIUserManagerHost &&

switches::IsNewAvatarMenu()) {