Issue 134043005: Fix for testing existence of oobe in login code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 134043005: Fix for testing existence of oobe in login code. (Closed)

Created:
6 years, 11 months ago by achuithb

Modified:
6 years, 11 months ago

Reviewers:
Tim Song

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix for testing existence of oobe in login code. We were using GetOobe to figure out if the oobe page existed. This creates an InspectorBackend, which creates an InspectorPage, which calls _EnablePageNotifications, which calls SyncRequest with a timeout of 60 sec. If the page goes away right before SyncRequest is called, we could end up waiting 60 sec. In general, GetOobe is too expensive if all we're interested in is checking the existence of oobe, so fix all instances of such checks to use OobeExists instead. BUG=331940 TEST=manual NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244325

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -7 lines)			Patch
	M	tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py	View		5 chunks	+11 lines, -7 lines	0 comments	Download
	M	tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/134043005/1

6 years, 11 months ago (2014-01-11 00:48:29 UTC) #3

Message was sent while issue was closed.

Change committed as 244325

Expand Messages | Collapse Messages