Source/core/page/DOMWindowPagePopup.h - Issue 134043004: Update page & frame classes to use OVERRIDE / FINAL when needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/DOMWindowPagePopup.h

Issue 134043004: Update page & frame classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/DOMWindowPagePopup.h

diff --git a/Source/core/page/DOMWindowPagePopup.h b/Source/core/page/DOMWindowPagePopup.h

index aa401a471005aec514c8573571b31827010f7192..0a2e8d88841c59aac449e3d33ccb1104ef3ac2c9 100644

--- a/Source/core/page/DOMWindowPagePopup.h

+++ b/Source/core/page/DOMWindowPagePopup.h

@@ -39,12 +39,12 @@ class DOMWindow;

class PagePopupClient;

class PagePopupController;

-class DOMWindowPagePopup : public Supplement<DOMWindow> {

+class DOMWindowPagePopup FINAL : public Supplement<DOMWindow> {

public:

static PagePopupController* pagePopupController(DOMWindow*);

static void install(DOMWindow*, PagePopupClient*);

static void uninstall(DOMWindow*);

- ~DOMWindowPagePopup();

+ virtual ~DOMWindowPagePopup();

private:

explicit DOMWindowPagePopup(PagePopupClient*);

« no previous file with comments | « Source/core/page/DOMSelection.h ('k') | Source/core/page/EventSource.h » ('j') | no next file with comments »