Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Side by Side Diff: Source/core/page/Page.h

Issue 134043004: Update page & frame classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/page/EventSource.h ('k') | Source/core/page/PageLifecycleNotifier.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserv ed. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserv ed.
3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 class Settings; 75 class Settings;
76 class SpellCheckerClient; 76 class SpellCheckerClient;
77 class StorageNamespace; 77 class StorageNamespace;
78 class UndoStack; 78 class UndoStack;
79 class ValidationMessageClient; 79 class ValidationMessageClient;
80 80
81 typedef uint64_t LinkHash; 81 typedef uint64_t LinkHash;
82 82
83 float deviceScaleFactor(Frame*); 83 float deviceScaleFactor(Frame*);
84 84
85 class Page : public Supplementable<Page>, public LifecycleContext<Page>, public SettingsDelegate { 85 class Page FINAL : public Supplementable<Page>, public LifecycleContext<Page>, p ublic SettingsDelegate {
86 WTF_MAKE_NONCOPYABLE(Page); 86 WTF_MAKE_NONCOPYABLE(Page);
87 friend class Settings; 87 friend class Settings;
88 public: 88 public:
89 static void scheduleForcedStyleRecalcForAllPages(); 89 static void scheduleForcedStyleRecalcForAllPages();
90 90
91 // It is up to the platform to ensure that non-null clients are provided whe re required. 91 // It is up to the platform to ensure that non-null clients are provided whe re required.
92 struct PageClients { 92 struct PageClients {
93 WTF_MAKE_NONCOPYABLE(PageClients); WTF_MAKE_FAST_ALLOCATED; 93 WTF_MAKE_NONCOPYABLE(PageClients); WTF_MAKE_FAST_ALLOCATED;
94 public: 94 public:
95 PageClients(); 95 PageClients();
96 ~PageClients(); 96 ~PageClients();
97 97
98 ChromeClient* chromeClient; 98 ChromeClient* chromeClient;
99 ContextMenuClient* contextMenuClient; 99 ContextMenuClient* contextMenuClient;
100 EditorClient* editorClient; 100 EditorClient* editorClient;
101 DragClient* dragClient; 101 DragClient* dragClient;
102 InspectorClient* inspectorClient; 102 InspectorClient* inspectorClient;
103 BackForwardClient* backForwardClient; 103 BackForwardClient* backForwardClient;
104 SpellCheckerClient* spellCheckerClient; 104 SpellCheckerClient* spellCheckerClient;
105 }; 105 };
106 106
107 explicit Page(PageClients&); 107 explicit Page(PageClients&);
108 ~Page(); 108 virtual ~Page();
109 109
110 FrameHost& frameHost() { return *m_frameHost; } 110 FrameHost& frameHost() { return *m_frameHost; }
111 111
112 void setNeedsRecalcStyleInAllFrames(); 112 void setNeedsRecalcStyleInAllFrames();
113 113
114 ViewportDescription viewportDescription() const; 114 ViewportDescription viewportDescription() const;
115 115
116 static void refreshPlugins(bool reload); 116 static void refreshPlugins(bool reload);
117 PluginData* pluginData() const; 117 PluginData* pluginData() const;
118 118
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 HashSet<MultisamplingChangedObserver*> m_multisamplingChangedObservers; 299 HashSet<MultisamplingChangedObserver*> m_multisamplingChangedObservers;
300 300
301 // A pointer to all the interfaces provided to in-process Frames for this Pa ge. 301 // A pointer to all the interfaces provided to in-process Frames for this Pa ge.
302 // FIXME: Most of the members of Page should move onto FrameHost. 302 // FIXME: Most of the members of Page should move onto FrameHost.
303 OwnPtr<FrameHost> m_frameHost; 303 OwnPtr<FrameHost> m_frameHost;
304 }; 304 };
305 305
306 } // namespace WebCore 306 } // namespace WebCore
307 307
308 #endif // Page_h 308 #endif // Page_h
OLDNEW
« no previous file with comments | « Source/core/page/EventSource.h ('k') | Source/core/page/PageLifecycleNotifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698