scheduler: Implement WebFrameScheduler and WebPageScheduler

components/scheduler/renderer/renderer_scheduler_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SCHEDULER_RENDERER_RENDERER_SCHEDULER_IMPL_H_
 #define COMPONENTS_SCHEDULER_RENDERER_RENDERER_SCHEDULER_IMPL_H_
 
 #include "base/atomicops.h"
 #include "base/synchronization/lock.h"
 #include "components/scheduler/child/idle_helper.h"
 #include "components/scheduler/child/pollable_thread_safe_flag.h"
 #include "components/scheduler/child/scheduler_helper.h"
 #include "components/scheduler/renderer/deadline_task_runner.h"
 #include "components/scheduler/renderer/renderer_scheduler.h"
 #include "components/scheduler/renderer/task_cost_estimator.h"
 #include "components/scheduler/renderer/user_model.h"
 #include "components/scheduler/scheduler_export.h"
 
 namespace base {
 namespace trace_event {
 class ConvertableToTraceFormat;
 }
 }
 
 namespace scheduler {
 
-class SCHEDULER_EXPORT RendererSchedulerImpl : public RendererScheduler,
-                                               public IdleHelper::Delegate {
+class SCHEDULER_EXPORT RendererSchedulerImpl
+    : public RendererScheduler,
+      public IdleHelper::Delegate,
+      public SchedulerHelper::Observer {
  public:
   RendererSchedulerImpl(
       scoped_refptr<SchedulerTaskRunnerDelegate> main_task_runner);
   ~RendererSchedulerImpl() override;
 
   // RendererScheduler implementation:
   scoped_refptr<TaskQueue> DefaultTaskRunner() override;
   scoped_refptr<SingleThreadIdleTaskRunner> IdleTaskRunner() override;
   scoped_refptr<base::SingleThreadTaskRunner> CompositorTaskRunner() override;
   scoped_refptr<base::SingleThreadTaskRunner> LoadingTaskRunner() override;
   scoped_refptr<TaskQueue> TimerTaskRunner() override;
+  scoped_refptr<TaskQueue> NewLoadingTaskRunner(const char* name) override;
+  scoped_refptr<TaskQueue> NewTimerTaskRunner(const char* name) override;
   void WillBeginFrame(const cc::BeginFrameArgs& args) override;
   void BeginFrameNotExpectedSoon() override;
   void DidCommitFrameToCompositor() override;
   void DidHandleInputEventOnCompositorThread(
       const blink::WebInputEvent& web_input_event,
       InputEventState event_state) override;
   void DidHandleInputEventOnMainThread(
       const blink::WebInputEvent& web_input_event) override;
   void DidAnimateForInputOnCompositorThread() override;
   void OnRendererHidden() override;
   void OnRendererVisible() override;
   void OnRendererBackgrounded() override;
   void OnRendererForegrounded() override;
   void OnPageLoadStarted() override;
   bool IsHighPriorityWorkAnticipated() override;
   bool ShouldYieldForHighPriorityWork() override;
   bool CanExceedIdleDeadlineIfRequired() const override;
   void AddTaskObserver(base::MessageLoop::TaskObserver* task_observer) override;
   void RemoveTaskObserver(
       base::MessageLoop::TaskObserver* task_observer) override;
   void Shutdown() override;
   void SuspendTimerQueue() override;
   void ResumeTimerQueue() override;
   void SetTimerQueueSuspensionWhenBackgroundedEnabled(bool enabled) override;
 
+  // TaskQueueManager::Observer implementation:
+  void OnUnregisterTaskQueue(const scoped_refptr<TaskQueue>& queue) override;
+
   // Test helpers.
   SchedulerHelper* GetSchedulerHelperForTesting();
   TaskCostEstimator* GetLoadingTaskCostEstimatorForTesting();
   TaskCostEstimator* GetTimerTaskCostEstimatorForTesting();
   base::TimeTicks CurrentIdleTaskDeadlineForTesting() const;
 
  private:
   friend class RendererSchedulerImplTest;
   friend class RendererSchedulerImplForTest;
 
@@ skipping 124 matching lines @@
 
   // The task cost estimators and the UserModel need to be reset upon page
   // nagigation. This function does that. Must be called from the main thread.
   void ResetForNavigationLocked();
 
   SchedulerHelper helper_;
   IdleHelper idle_helper_;
 
   const scoped_refptr<TaskQueue> control_task_runner_;
   const scoped_refptr<TaskQueue> compositor_task_runner_;
-  const scoped_refptr<TaskQueue> loading_task_runner_;
-  const scoped_refptr<TaskQueue> timer_task_runner_;
+  std::set<scoped_refptr<TaskQueue>> loading_task_runners_;
+  std::set<scoped_refptr<TaskQueue>> timer_task_runners_;

[rmcilroy, 2015/09/18 13:15:46]

Any reason for this to be a set rather than a vector?

[Sami, 2015/09/21 10:52:36]

I think Alex wanted to keep the removals efficient -- but I doubt in practice it
makes a difference either way. I'm leaning toward keeping these as sets since it
we don't want any duplicates in there -- but happy to turn into vectors is you
prefer?

(unordered_set is still banned it seems.)

[rmcilroy, 2015/09/23 09:44:25]

This is fine.

+  scoped_refptr<TaskQueue> default_loading_task_runner_;
+  scoped_refptr<TaskQueue> default_timer_task_runner_;
 
   base::Closure update_policy_closure_;
   DeadlineTaskRunner delayed_update_policy_runner_;
   CancelableClosureHolder end_renderer_hidden_idle_period_closure_;
   CancelableClosureHolder suspend_timers_when_backgrounded_closure_;
 
   // We have decided to improve thread safety at the cost of some boilerplate
   // (the accessors) for the following data members.
 
   struct MainThreadOnly {
@@ skipping 81 matching lines @@
 
   PollableThreadSafeFlag policy_may_need_update_;
   base::WeakPtrFactory<RendererSchedulerImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RendererSchedulerImpl);
 };
 
 }  // namespace scheduler
 
 #endif  // COMPONENTS_SCHEDULER_RENDERER_RENDERER_SCHEDULER_IMPL_H_