Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1340323002: Revert of [heap] Concurrency support for heap book-keeping info (Closed)

Created:
5 years, 3 months ago by Michael Lippautz
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Concurrency support for heap book-keeping info (patchset #4 id:60001 of https://codereview.chromium.org/1340923004/ ) Reason for revert: crashing: http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug%20-%203/builds/4716 Original issue's description: > [heap] Concurrency support for heap book-keeping info. > > Adds concurrency support for: > - MemoryChunk: Fragmentation counters > - MemoryChunk: High-water mark > - MemoryAllocator: Lowest and highest ever allocated addresses, size, and > capacity > > R=hpayer@chromium.org > BUG=chromium:524425 > LOG=N > > Committed: https://crrev.com/63190721cda4966e01d71e92a730ce48ea789fbc > Cr-Commit-Position: refs/heads/master@{#30749} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524425 Committed: https://crrev.com/0db34dbe8111f8670c82bb4c42110400a9050d08 Cr-Commit-Position: refs/heads/master@{#30752}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -101 lines) Patch
M src/atomic-utils.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/heap/spaces.h View 9 chunks +56 lines, -72 lines 0 comments Download
M src/heap/spaces.cc View 8 chunks +20 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Lippautz
Created Revert of [heap] Concurrency support for heap book-keeping info
5 years, 3 months ago (2015-09-15 15:11:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340323002/1
5 years, 3 months ago (2015-09-15 15:11:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 15:11:43 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 15:11:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0db34dbe8111f8670c82bb4c42110400a9050d08
Cr-Commit-Position: refs/heads/master@{#30752}

Powered by Google App Engine
This is Rietveld 408576698