Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1340303002: [mips] Fix mips unittests (to not use invalid load representation). (Closed)

Created:
5 years, 3 months ago by Jarin
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[mips] Fix mips unittests (to not use invalid load representation). Committed: https://crrev.com/edf6d2adbd01baa5e1d9a1132ce0d121ac21b220 Cr-Commit-Position: refs/heads/master@{#30753}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/unittests/compiler/mips/instruction-selector-mips-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jarin
Could you take a look, please?
5 years, 3 months ago (2015-09-15 13:52:39 UTC) #2
Jarin
(This should fix the waterfall.)
5 years, 3 months ago (2015-09-15 13:53:14 UTC) #3
paul.l...
LGTM. Thanks for finding this!
5 years, 3 months ago (2015-09-15 14:28:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340303002/1
5 years, 3 months ago (2015-09-15 15:49:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 15:50:38 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 15:50:54 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/edf6d2adbd01baa5e1d9a1132ce0d121ac21b220
Cr-Commit-Position: refs/heads/master@{#30753}

Powered by Google App Engine
This is Rietveld 408576698