Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1340263003: Rename IdleCallbackDeadline to IdleDeadline to be in sync with spec. (Closed)

Created:
5 years, 3 months ago by rmcilroy
Modified:
5 years, 3 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, Sami, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename IdleCallbackDeadline to IdleDeadline to be in sync with spec. Based on requestIdleCallback spec at https://w3c.github.io/requestidlecallback/. BUG=514651 Committed: https://crrev.com/39d67e334a967b04f90e9d862fc10dee7aa2c215 git-svn-id: svn://svn.chromium.org/blink/trunk@202276 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -109 lines) Patch
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
D Source/core/dom/IdleCallbackDeadline.h View 1 chunk +0 lines, -44 lines 0 comments Download
D Source/core/dom/IdleCallbackDeadline.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
D Source/core/dom/IdleCallbackDeadline.idl View 1 chunk +0 lines, -11 lines 0 comments Download
A + Source/core/dom/IdleDeadline.h View 4 chunks +7 lines, -7 lines 0 comments Download
A + Source/core/dom/IdleDeadline.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + Source/core/dom/IdleDeadline.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/IdleRequestCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/IdleRequestCallback.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ScriptedIdleTaskController.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/ScriptedIdleTaskController.cpp View 5 chunks +7 lines, -7 lines 0 comments Download

Depends on Patchset:

Issue 777213002 Patch 60001

Dependent Patchsets:

Issue 1344053002 Patch 1
Issue 1344053002 Patch 20001

Messages

Total messages: 7 (2 generated)
rmcilroy
Jochen: could you please take a look? This is a simple rename of IdleCallbackDeadline->IdleDeadline (The ...
5 years, 3 months ago (2015-09-15 13:50:20 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-15 13:51:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340263003/1
5 years, 3 months ago (2015-09-15 14:36:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202276
5 years, 3 months ago (2015-09-15 15:52:49 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:45:29 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/39d67e334a967b04f90e9d862fc10dee7aa2c215

Powered by Google App Engine
This is Rietveld 408576698