Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1340253004: [heap] Let caller figure out target space for evacuation when compacting. (Closed)

Created:
5 years, 3 months ago by Michael Lippautz
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Let caller figure out target space for evacuation when compacting. R=hpayer@chromium.org BUG=chromium:524425 LOG=N Committed: https://crrev.com/7611c3b98b2b15c00aca318a7d24cd9161fb989d Cr-Commit-Position: refs/heads/master@{#30742}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M src/heap/mark-compact.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.cc View 1 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Michael Lippautz
5 years, 3 months ago (2015-09-15 09:37:23 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340253004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340253004/1
5 years, 3 months ago (2015-09-15 09:41:23 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 10:29:25 UTC) #5
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/1340253004/diff/1/src/heap/mark-compact.h File src/heap/mark-compact.h (right): https://codereview.chromium.org/1340253004/diff/1/src/heap/mark-compact.h#newcode884 src/heap/mark-compact.h:884: void EvacuateLiveObjectsFromPage(Page* p, PagedSpace* to_space); Let's rename it ...
5 years, 3 months ago (2015-09-15 10:38:42 UTC) #6
Michael Lippautz
https://codereview.chromium.org/1340253004/diff/1/src/heap/mark-compact.h File src/heap/mark-compact.h (right): https://codereview.chromium.org/1340253004/diff/1/src/heap/mark-compact.h#newcode884 src/heap/mark-compact.h:884: void EvacuateLiveObjectsFromPage(Page* p, PagedSpace* to_space); On 2015/09/15 10:38:42, Hannes ...
5 years, 3 months ago (2015-09-15 10:41:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340253004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340253004/20001
5 years, 3 months ago (2015-09-15 10:41:17 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-15 11:44:51 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 11:45:09 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7611c3b98b2b15c00aca318a7d24cd9161fb989d
Cr-Commit-Position: refs/heads/master@{#30742}

Powered by Google App Engine
This is Rietveld 408576698