Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1340223003: create SkBitmapProvider to abstract images and bitmaps (Closed)

Created:
5 years, 3 months ago by reed1
Modified:
5 years, 3 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

create SkBitmapProvider to abstract images and bitmaps BUG=skia: Committed: https://skia.googlesource.com/skia/+/98ed7b6d01c16ad9ace652ec25861689d765d0b5

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : change 0 to default width/height #

Patch Set 4 : remove obsolete comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -72 lines) Patch
M src/core/SkBitmapCache.h View 4 chunks +18 lines, -4 lines 0 comments Download
M src/core/SkBitmapCache.cpp View 1 2 3 6 chunks +70 lines, -16 lines 0 comments Download
M src/core/SkBitmapController.h View 3 chunks +32 lines, -5 lines 0 comments Download
M src/core/SkBitmapController.cpp View 13 chunks +103 lines, -41 lines 0 comments Download
M tests/SkResourceCacheTest.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
reed1
WIP
5 years, 3 months ago (2015-09-15 19:02:00 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340223003/20001
5 years, 3 months ago (2015-09-15 19:08:57 UTC) #4
f(malita)
lgtm
5 years, 3 months ago (2015-09-15 19:20:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340223003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340223003/60001
5 years, 3 months ago (2015-09-15 19:32:18 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 19:38:18 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/98ed7b6d01c16ad9ace652ec25861689d765d0b5

Powered by Google App Engine
This is Rietveld 408576698