content/browser/web_contents/web_contents_impl.h - Issue 1340163002: PlzNavigate: fix timing issue in app window creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 1340163002: PlzNavigate: fix timing issue in app window creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation-throttle

Patch Set: Addressed comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | content/public/browser/web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index f94639f921df4d22aea97de6d096c4f2448cf27d..89fe6eddd821c3b72c8fd4bf4083258550ce2b82 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -516,6 +516,7 @@ class CONTENT_EXPORT WebContentsImpl

void DidStartNavigation(NavigationHandle* navigation_handle) override;

void DidRedirectNavigation(NavigationHandle* navigation_handle) override;

+ void ReadyToCommitNavigation(NavigationHandle* navigation_handle) override;

void DidCommitNavigation(NavigationHandle* navigation_handle) override;

void DidFinishNavigation(NavigationHandle* navigation_handle) override;

void DidStartProvisionalLoad(RenderFrameHostImpl* render_frame_host,