extensions/browser/app_window/app_window_contents.h - Issue 1340163002: PlzNavigate: fix timing issue in app window creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/app_window/app_window_contents.h

Issue 1340163002: PlzNavigate: fix timing issue in app window creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation-throttle

Patch Set: Addressed Nasko's comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/app_window/app_window.cc ('K') | « extensions/browser/app_window/app_window.cc ('k') | extensions/browser/app_window/app_window_contents.cc » ('j') | extensions/browser/app_window/app_window_contents.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/app_window/app_window_contents.h

diff --git a/extensions/browser/app_window/app_window_contents.h b/extensions/browser/app_window/app_window_contents.h

index 7656a682c4b0742a6168ccccc4fb54ef5153c5dc..559bd92d75b17226532c5e1395332b20faca3f90 100644

--- a/extensions/browser/app_window/app_window_contents.h

+++ b/extensions/browser/app_window/app_window_contents.h

@@ -42,6 +42,7 @@ class AppWindowContentsImpl : public AppWindowContents,

private:

// content::WebContentsObserver

bool OnMessageReceived(const IPC::Message& message) override;

+ void ReadyToCommitNavigation(content::NavigationHandle* handle) override;

void UpdateDraggableRegions(const std::vector<DraggableRegion>& regions);

void SuspendRenderFrameHost(content::RenderFrameHost* rfh);