Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: content/public/browser/web_contents_observer.h

Issue 1340163002: PlzNavigate: fix timing issue in app window creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation-throttle
Patch Set: Addressed Nasko's comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents_observer.h
diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h
index d310cb229e485af2d66577fff629b5c71e791334..9a3fc83a67bc2dd409c3521efc1c8610fba49311 100644
--- a/content/public/browser/web_contents_observer.h
+++ b/content/public/browser/web_contents_observer.h
@@ -121,8 +121,9 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,
// Called when a navigation started in the WebContents. |navigation_handle|
// is unique to a specific navigation. The same |navigation_handle| will be
- // provided on subsequent calls to DidRedirect/Commit/FinishNavigation
- // related to this navigation.
+ // provided on subsequent calls to
+ // DidRedirect/Commit/FinishNavigation/AboutToCommitNavigation related to
+ // this navigation.
//
// Note that this is fired by navigations in any frame of the WebContents,
// not just the main frame.
@@ -139,6 +140,12 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,
// Called when a navigation encountered a server redirect.
virtual void DidRedirectNavigation(NavigationHandle* navigation_handle) {}
+ // PlzNavigate
+ // Called when the navigation is ready to be committed in a renderer. This is
+ // the first point in time where a RenderFrameHost is associated with the
+ // navigation.
nasko 2015/09/16 21:37:50 One thing I forgot to mention. Let's add a comment
clamy 2015/09/16 22:19:39 Done.
+ virtual void ReadyToCommitNavigation(NavigationHandle* navigation_handle) {}
+
// Called when a navigation was committed.
virtual void DidCommitNavigation(NavigationHandle* navigation_handle) {}

Powered by Google App Engine
This is Rietveld 408576698