content/browser/web_contents/web_contents_impl.cc - Issue 1340163002: PlzNavigate: fix timing issue in app window creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1340163002: PlzNavigate: fix timing issue in app window creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation-throttle

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/public/browser/web_contents_observer.h » ('j') | content/public/browser/web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index a93eea7e70809ddf518856e59d4eeb4eb79a8e96..f8bd56c202e7aa4c144bd29f6ab87ef9fdb1d07a 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -2788,6 +2788,12 @@ void WebContentsImpl::DidRedirectNavigation(

DidRedirectNavigation(navigation_handle));

}

+void WebContentsImpl::AboutToCommitNavigation(

+ NavigationHandle* navigation_handle) {

+ FOR_EACH_OBSERVER(WebContentsObserver, observers_,

+ AboutToCommitNavigation(navigation_handle));

void WebContentsImpl::DidCommitNavigation(NavigationHandle* navigation_handle) {

FOR_EACH_OBSERVER(WebContentsObserver, observers_,

DidCommitNavigation(navigation_handle));