content/browser/frame_host/navigator_impl.cc - Issue 1340163002: PlzNavigate: fix timing issue in app window creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 1340163002: PlzNavigate: fix timing issue in app window creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation-throttle

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigator_delegate.h ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | content/public/browser/web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index b2be362dfb61d9b6904098078d4c62f5f2c1cbc6..17ce9bd5100503a200c4c9553785a2871af72527 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -738,6 +738,7 @@ void NavigatorImpl::CommitNavigation(FrameTreeNode* frame_tree_node,

render_frame_host, navigation_request->common_params().url);

navigation_request->TransferNavigationHandleOwnership(render_frame_host);

+ delegate_->AboutToCommitNavigation(render_frame_host->navigation_handle());

render_frame_host->CommitNavigation(response, body.Pass(),

navigation_request->common_params(),

navigation_request->request_params());

@@ -768,6 +769,7 @@ void NavigatorImpl::FailedNavigation(FrameTreeNode* frame_tree_node,

render_frame_host, navigation_request->common_params().url);

navigation_request->TransferNavigationHandleOwnership(render_frame_host);

+ delegate_->AboutToCommitNavigation(render_frame_host->navigation_handle());

render_frame_host->FailedNavigation(navigation_request->common_params(),

navigation_request->request_params(),

has_stale_copy_in_cache, error_code);