Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: content/test/web_contents_observer_sanity_checker.cc

Issue 1340163002: PlzNavigate: fix timing issue in app window creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation-throttle
Patch Set: Addressed nits Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/web_contents_observer_sanity_checker.cc
diff --git a/content/test/web_contents_observer_sanity_checker.cc b/content/test/web_contents_observer_sanity_checker.cc
index 09151e89135750a398e7a6b909227f4418abb1ed..82bcb60461840a005453f0d271ce50cd3de1e7bd 100644
--- a/content/test/web_contents_observer_sanity_checker.cc
+++ b/content/test/web_contents_observer_sanity_checker.cc
@@ -143,6 +143,15 @@ void WebContentsObserverSanityChecker::DidRedirectNavigation(
CHECK(!navigation_handle->HasCommittedErrorPage());
}
+void WebContentsObserverSanityChecker::ReadyToCommitNavigation(
+ NavigationHandle* navigation_handle) {
+ CHECK(NavigationIsOngoing(navigation_handle));
+ CHECK(!NavigationIsOngoingAndCommitted(navigation_handle));
+
+ CHECK(!navigation_handle->HasCommittedDocument());
+ CHECK(!navigation_handle->HasCommittedErrorPage());
+}
+
void WebContentsObserverSanityChecker::DidCommitNavigation(
NavigationHandle* navigation_handle) {
CHECK(NavigationIsOngoing(navigation_handle));
« no previous file with comments | « content/test/web_contents_observer_sanity_checker.h ('k') | extensions/browser/api/app_window/app_window_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698