Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1340163002: PlzNavigate: fix timing issue in app window creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation-throttle
Patch Set: Addressed nits Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
(...skipping 2770 matching lines...) Expand 10 before | Expand all | Expand 10 after
2781 FOR_EACH_OBSERVER(WebContentsObserver, observers_, 2781 FOR_EACH_OBSERVER(WebContentsObserver, observers_,
2782 DidStartNavigation(navigation_handle)); 2782 DidStartNavigation(navigation_handle));
2783 } 2783 }
2784 2784
2785 void WebContentsImpl::DidRedirectNavigation( 2785 void WebContentsImpl::DidRedirectNavigation(
2786 NavigationHandle* navigation_handle) { 2786 NavigationHandle* navigation_handle) {
2787 FOR_EACH_OBSERVER(WebContentsObserver, observers_, 2787 FOR_EACH_OBSERVER(WebContentsObserver, observers_,
2788 DidRedirectNavigation(navigation_handle)); 2788 DidRedirectNavigation(navigation_handle));
2789 } 2789 }
2790 2790
2791 void WebContentsImpl::ReadyToCommitNavigation(
2792 NavigationHandle* navigation_handle) {
2793 FOR_EACH_OBSERVER(WebContentsObserver, observers_,
2794 ReadyToCommitNavigation(navigation_handle));
2795 }
2796
2791 void WebContentsImpl::DidCommitNavigation(NavigationHandle* navigation_handle) { 2797 void WebContentsImpl::DidCommitNavigation(NavigationHandle* navigation_handle) {
2792 FOR_EACH_OBSERVER(WebContentsObserver, observers_, 2798 FOR_EACH_OBSERVER(WebContentsObserver, observers_,
2793 DidCommitNavigation(navigation_handle)); 2799 DidCommitNavigation(navigation_handle));
2794 } 2800 }
2795 2801
2796 void WebContentsImpl::DidFinishNavigation(NavigationHandle* navigation_handle) { 2802 void WebContentsImpl::DidFinishNavigation(NavigationHandle* navigation_handle) {
2797 FOR_EACH_OBSERVER(WebContentsObserver, observers_, 2803 FOR_EACH_OBSERVER(WebContentsObserver, observers_,
2798 DidFinishNavigation(navigation_handle)); 2804 DidFinishNavigation(navigation_handle));
2799 } 2805 }
2800 2806
(...skipping 1826 matching lines...) Expand 10 before | Expand all | Expand 10 after
4627 return NULL; 4633 return NULL;
4628 } 4634 }
4629 4635
4630 void WebContentsImpl::SetForceDisableOverscrollContent(bool force_disable) { 4636 void WebContentsImpl::SetForceDisableOverscrollContent(bool force_disable) {
4631 force_disable_overscroll_content_ = force_disable; 4637 force_disable_overscroll_content_ = force_disable;
4632 if (view_) 4638 if (view_)
4633 view_->SetOverscrollControllerEnabled(CanOverscrollContent()); 4639 view_->SetOverscrollControllerEnabled(CanOverscrollContent());
4634 } 4640 }
4635 4641
4636 } // namespace content 4642 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/public/browser/web_contents_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698