[OriginChip] Add options for the position of the origin chip.

chrome/browser/ui/views/toolbar/toolbar_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
 
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/i18n/number_formatting.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/command_updater.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/search/search.h"
 #include "chrome/browser/themes/theme_service.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_command_controller.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_content_setting_bubble_model_delegate.h"
 #include "chrome/browser/ui/browser_instant_controller.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/global_error/global_error_service.h"
 #include "chrome/browser/ui/global_error/global_error_service_factory.h"
@@ skipping 195 matching lines @@
 #else
   app_menu_ = new WrenchToolbarButton(this);
 #endif
   app_menu_->set_border(NULL);
   app_menu_->EnableCanvasFlippingForRTLUI(true);
   app_menu_->SetAccessibleName(l10n_util::GetStringUTF16(IDS_ACCNAME_APP));
   app_menu_->SetTooltipText(l10n_util::GetStringUTF16(IDS_APPMENU_TOOLTIP));
   app_menu_->set_id(VIEW_ID_APP_MENU);
 
   // Always add children in order from left to right, for accessibility.
+  site_chip_view_ = new SiteChipView(this);
+  chrome::OriginChipPosition origin_chip_position =
+      chrome::GetOriginChipPosition();
   AddChildView(back_);
   AddChildView(forward_);
   AddChildView(reload_);
   AddChildView(home_);
+  if (origin_chip_position == chrome::ORIGIN_CHIP_LEFT_OF_LOCATION_BAR)
+    AddChildView(site_chip_view_);
   AddChildView(location_bar_);
-  site_chip_view_ = new SiteChipView(this);
-  AddChildView(site_chip_view_);
+  if (origin_chip_position == chrome::ORIGIN_CHIP_RIGHT_OF_LOCATION_BAR)
+    AddChildView(site_chip_view_);
   AddChildView(browser_actions_);
+  if (origin_chip_position == chrome::ORIGIN_CHIP_LEFT_OF_MENU ||
+      origin_chip_position == chrome::ORIGIN_CHIP_DISABLED)
+    AddChildView(site_chip_view_);
   AddChildView(app_menu_);
 
   LoadImages();
 
   // Add any necessary badges to the menu item based on the system state.
   // Do this after |app_menu_| has been added as a bubble may be shown that
   // needs the widget (widget found by way of app_menu_->GetWidget()).
   UpdateAppMenuState();
 
   location_bar_->Init();
@@ skipping 303 matching lines @@
   //                http://crbug.com/5540
   bool maximized = browser_->window() && browser_->window()->IsMaximized();
   int back_width = back_->GetPreferredSize().width();
   if (maximized) {
     back_->SetBounds(0, child_y, back_width + kLeftEdgeSpacing, child_height);
     back_->SetLeadingMargin(kLeftEdgeSpacing);
   } else {
     back_->SetBounds(kLeftEdgeSpacing, child_y, back_width, child_height);
     back_->SetLeadingMargin(0);
   }
+  int button_spacing = GetButtonSpacing();
+  int next_element_x = back_->bounds().right() + button_spacing;
 
-  int button_spacing = GetButtonSpacing();
-  forward_->SetBounds(back_->x() + back_->width() + button_spacing,
-      child_y, forward_->GetPreferredSize().width(), child_height);
+  forward_->SetBounds(next_element_x, child_y,
+                      forward_->GetPreferredSize().width(), child_height);
+  next_element_x = forward_->bounds().right() + button_spacing;
 
-  reload_->SetBounds(forward_->x() + forward_->width() + button_spacing,
-      child_y, reload_->GetPreferredSize().width(), child_height);
+  reload_->SetBounds(next_element_x, child_y,
+                     reload_->GetPreferredSize().width(), child_height);
+  next_element_x = reload_->bounds().right();
 
   if (show_home_button_.GetValue()) {
     home_->SetVisible(true);
-    home_->SetBounds(reload_->x() + reload_->width() + button_spacing,
-                     child_y, home_->GetPreferredSize().width(), child_height);
+    home_->SetBounds(next_element_x + button_spacing, child_y,
+                     home_->GetPreferredSize().width(), child_height);
   } else {
     home_->SetVisible(false);
-    home_->SetBounds(reload_->x() + reload_->width(), child_y, 0, child_height);
+    home_->SetBounds(next_element_x, child_y, 0, child_height);
   }
+  next_element_x = home_->bounds().right() + kStandardSpacing;
 
   int browser_actions_width = browser_actions_->GetPreferredSize().width();
-
   int app_menu_width = app_menu_->GetPreferredSize().width();
-  int location_x = home_->x() + home_->width() + kStandardSpacing;
   int available_width = std::max(0, width() - kRightEdgeSpacing -
-      app_menu_width - browser_actions_width - location_x);
+      app_menu_width - browser_actions_width - next_element_x);
 
   // Cap site chip width at 1/2 the size available to the location bar.
   site_chip_view_->SetVisible(site_chip_view_->ShouldShow());
   int site_chip_width = site_chip_view_->GetPreferredSize().width();
   site_chip_width = std::max(0, std::min(site_chip_width,
       (available_width - kStandardSpacing) / 2));
   if (site_chip_view_->visible())
     available_width -= site_chip_width + kStandardSpacing;
 
+  chrome::OriginChipPosition origin_chip_position =
+      chrome::GetOriginChipPosition();
+  if (origin_chip_position == chrome::ORIGIN_CHIP_LEFT_OF_LOCATION_BAR) {
+    site_chip_view_->SetBounds(next_element_x, child_y,
+                               site_chip_width, child_height);
+    next_element_x = site_chip_view_->bounds().right() + kStandardSpacing;
+  }
+
   int location_height = location_bar_->GetPreferredSize().height();
   int location_y = (height() - location_height + 1) / 2;
-  location_bar_->SetBounds(location_x, location_y, std::max(available_width, 0),
-                           location_height);
-  int browser_actions_x = location_bar_->bounds().right();
+  location_bar_->SetBounds(next_element_x, location_y,
+                           std::max(available_width, 0), location_height);
+  next_element_x = location_bar_->bounds().right();
 
-  if (site_chip_view_->visible()) {
-    site_chip_view_->SetBounds(browser_actions_x + kStandardSpacing,
-                               child_y,
-                               site_chip_width,
-                               child_height);
-    browser_actions_x = site_chip_view_->bounds().right();
+  if (origin_chip_position == chrome::ORIGIN_CHIP_RIGHT_OF_LOCATION_BAR) {
+    site_chip_view_->SetBounds(next_element_x + kStandardSpacing, child_y,
+                               site_chip_width, child_height);
+    next_element_x = site_chip_view_->bounds().right();
   }
 
-  browser_actions_->SetBounds(browser_actions_x, 0,
+  browser_actions_->SetBounds(next_element_x, 0,
                               browser_actions_width, height());
+  next_element_x = browser_actions_->bounds().right();
 
   // The browser actions need to do a layout explicitly, because when an
   // extension is loaded/unloaded/changed, BrowserActionContainer removes and
   // re-adds everything, regardless of whether it has a page action. For a
   // page action, browser action bounds do not change, as a result of which
   // SetBounds does not do a layout at all.
   // TODO(sidchat): Rework the above behavior so that explicit layout is not
   //                required.
   browser_actions_->Layout();
 
+  if (origin_chip_position == chrome::ORIGIN_CHIP_LEFT_OF_MENU) {
+    site_chip_view_->SetBounds(next_element_x, child_y,
+                               site_chip_width, child_height);
+    next_element_x = site_chip_view_->bounds().right() + kStandardSpacing;

[msw, 2014/01/10 18:26:04]

nit: why add spacing between the origin chip and menu, if there is no space
between browser actions and menu? Does the browser actions container have
internal padding?

[Justin Donnelly, 2014/01/10 20:11:31]

Yes, the browser actions container adds the spacing.  See
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

+  }
+
   // Extend the app menu to the screen's right edge in maximized mode just like
   // we extend the back button to the left edge.
   if (maximized)
     app_menu_width += kRightEdgeSpacing;
-  app_menu_->SetBounds(browser_actions_->x() + browser_actions_width, child_y,
-                       app_menu_width, child_height);
+  app_menu_->SetBounds(next_element_x, child_y, app_menu_width, child_height);
 }
 
 bool ToolbarView::HitTestRect(const gfx::Rect& rect) const {
   // Fall through to the tab strip above us if none of |rect| intersects
   // with this view (intersection with the top shadow edge does not
   // count as intersection with this view).
   if (rect.bottom() < content_shadow_height())
     return false;
   // Otherwise let our superclass take care of it.
   return AccessiblePaneView::HitTestRect(rect);
@@ skipping 179 matching lines @@
 
 void ToolbarView::OnShowHomeButtonChanged() {
   Layout();
   SchedulePaint();
 }
 
 int ToolbarView::content_shadow_height() const {
   return browser_->host_desktop_type() == chrome::HOST_DESKTOP_TYPE_ASH ?
       kContentShadowHeightAsh : kContentShadowHeight;
 }