Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 134013002: Upgrade align-self and align-items parsing to CSS 3 (Closed)

Created:
6 years, 11 months ago by Julien - ping for review
Modified:
6 years, 11 months ago
Reviewers:
ojan, darktears
CC:
blink-reviews, zoltan1, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears
Visibility:
Public.

Description

Upgrade align-self and align-items parsing to CSS 3 This change migrates the 2 properties to the CSS 3 Alignment parsing. The new parsing is identical to how we parse 'justify-self'. The 2 properties need to be migrated together as they are used in tandem in CSSComputedStyleDeclaration. This change also removes EAlignItems as it is now unused. BUG=249451 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165264

Patch Set 1 #

Patch Set 2 : Fixed the failing tests #

Patch Set 3 : Really fix the tests #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+713 lines, -118 lines) Patch
M LayoutTests/css3/flexbox/css-properties.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/css3/flexbox/css-properties-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
A LayoutTests/fast/alignment/parse-align-items.html View 1 chunk +232 lines, -0 lines 0 comments Download
A LayoutTests/fast/alignment/parse-align-items-expected.txt View 1 chunk +61 lines, -0 lines 0 comments Download
A LayoutTests/fast/alignment/parse-align-self.html View 1 chunk +234 lines, -0 lines 0 comments Download
A LayoutTests/fast/alignment/parse-align-self-expected.txt View 1 chunk +61 lines, -0 lines 0 comments Download
M LayoutTests/svg/css/getComputedStyle-basic-expected.txt View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 3 chunks +20 lines, -13 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -50 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 2 4 chunks +11 lines, -4 lines 2 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 2 chunks +24 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFlexibleBox.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFlexibleBox.cpp View 1 2 8 chunks +33 lines, -23 lines 0 comments Download
M Source/core/rendering/RenderFullScreen.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMenuList.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 3 chunks +12 lines, -6 lines 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.h View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.cpp View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Julien - ping for review
More parsing upgrade for CSS 3 alignment properties.
6 years, 11 months ago (2014-01-14 18:55:13 UTC) #1
ojan
https://codereview.chromium.org/134013002/diff/80001/Source/core/css/parser/BisonCSSParser-in.cpp File Source/core/css/parser/BisonCSSParser-in.cpp (right): https://codereview.chromium.org/134013002/diff/80001/Source/core/css/parser/BisonCSSParser-in.cpp#newcode2739 Source/core/css/parser/BisonCSSParser-in.cpp:2739: ASSERT(RuntimeEnabledFeatures::cssGridLayoutEnabled()); I'm confused, don't align-self and align-items also apply ...
6 years, 11 months ago (2014-01-15 01:16:51 UTC) #2
Julien - ping for review
https://codereview.chromium.org/134013002/diff/80001/Source/core/css/parser/BisonCSSParser-in.cpp File Source/core/css/parser/BisonCSSParser-in.cpp (right): https://codereview.chromium.org/134013002/diff/80001/Source/core/css/parser/BisonCSSParser-in.cpp#newcode2739 Source/core/css/parser/BisonCSSParser-in.cpp:2739: ASSERT(RuntimeEnabledFeatures::cssGridLayoutEnabled()); On 2014/01/15 01:16:51, ojan wrote: > I'm confused, ...
6 years, 11 months ago (2014-01-15 19:10:22 UTC) #3
ojan
lgtm
6 years, 11 months ago (2014-01-17 00:52:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/134013002/80001
6 years, 11 months ago (2014-01-17 00:52:41 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 01:01:36 UTC) #6
Message was sent while issue was closed. 
Change committed as 165264

Powered by Google App Engine
This is Rietveld 408576698